-
Notifications
You must be signed in to change notification settings - Fork 7
ACTWorkKeys Assessment #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| {% endif %} | ||
|
|
||
| {% if "${SCHOOL_YEAR}" != "2022" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the file different only in 2022? Or is it 2022 and beyond? Like if someone sent '2023' as the school_year, should the logic below apply?
| @@ -0,0 +1,148 @@ | |||
| # ACTWorkKeys Assessment Bundle Documentation | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we merge this, we will remove this file and the hierarchy file from the bundle itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, should I remove this link from the README file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please!
| cert: CompositeScore | ||
| - operation: map_values | ||
| column: CompositeScore | ||
| map_file: ./seeds/certificateLevelMapping.csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sending both the composite score as-is and the mapped values? or only the mapped values? Typically we avoid mapping values because users will want to see those underlying values that are accustomed to seeing in the file itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sending the mapped values. Do you mean to send these values in studenAssessment.jsonl as they are in the sample file, right?
|
@msuarezcrocus This is ready for dev/qc |
…ame. Added optional fields to input source.
@jalvord1 The ACTWorkKeys bundle is ready for your review.